Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add workerId to TestCaseStarted #34

Merged
merged 12 commits into from
Oct 6, 2022
Merged

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Aug 25, 2022

🤔 What's changed?

Add an optional workerId field to TestCaseStarted message.

⚡️ What's your motivation?

See cucumber/cucumber-js#2085 (comment)

Cucumber implementations that support parallel running via worker processes or some distributed model can set workerId when a test case is started.

Cucumber itself won’t do anything with this (at least initially), but it will allow third-party reporting tools to do some useful reporting on the parallel run.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss changed the title add property to json schema add workerId to TestCaseStarted Aug 25, 2022
@davidjgoss davidjgoss marked this pull request as ready for review August 25, 2022 19:03
@mattwynne mattwynne added this to the v20 milestone Oct 3, 2022
@davidjgoss davidjgoss merged commit 3e35cc4 into main Oct 6, 2022
@davidjgoss davidjgoss deleted the test-case-started-worker-id branch October 6, 2022 08:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants