Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add name field to package.cjs.json #36

Merged
merged 3 commits into from
Sep 7, 2022
Merged

add name field to package.cjs.json #36

merged 3 commits into from
Sep 7, 2022

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Aug 28, 2022

🤔 What's changed?

add name field to package.cjs.json

⚡️ What's your motivation?

Tools like api-extractor look for a name in the closest package file, so it should always be present. This is currently blocking a piece of work in cucumber-js.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss merged commit d2faf89 into main Sep 7, 2022
@davidjgoss davidjgoss deleted the package-cjs-name branch September 7, 2022 10:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant