feat(main): add status controller sync #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuisongliu
force-pushed
the
status_sync
branch
5 times, most recently
from
0dc9745 to
e9fd07b
Compare
Signed-off-by: cuisongliu <cuisongliu@qq.com>
cuisongliu
force-pushed
the
status_sync
branch
from
e9fd07b to
c8a5334
Compare
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the configuration and setup of the AutoMQ service. The changes primarily focus on enhancing environment variable handling, updating configuration files, and modifying scripts for better compatibility and performance.
Configuration Updates:
config/samples/infra_v1beta1_automq.yaml: Updated the AutoMQ sample configuration to include S3 and broker settings, as well as JVM options and cluster ID.Environment Variable Handling:
cmd/main.go: Improved the handling of theENABLE_WEBHOOKSenvironment variable by usingos.LookupEnvto avoid potential errors.Script Enhancements:
defaults/up.sh: Modified thekafka_upfunction to update S3 bucket configuration keys and exportKAFKA_HEAP_OPTSfor better performance. [1] [2]Code Cleanup:
api/v1beta1/automq_types.go: Removed the unusedAutoMQUnknownphase constant.