feat(main): fix panic for pipelines #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the
AutoMQReconciler
to change the return types of various pipeline functions fromcontext.Context
tobool
, simplifying the logic for determining whether to continue the pipeline.Changes to Return Types:
internal/controller/automq_controller.go
: Changed the return type of pipeline functionss3Service
,scriptConfigmap
, andsyncBrokers
fromcontext.Context
tobool
. [1] [2] [3]internal/controller/automq_controller_b.go
: Changed the return type ofsyncBrokerScale
andsyncKafkaBootstrapService
fromcontext.Context
tobool
. [1] [2]internal/controller/automq_controller_c.go
: Changed the return type ofsyncControllersScale
andsyncControllers
fromcontext.Context
tobool
. [1] [2]Simplification of Pipeline Logic:
internal/controller/automq_controller.go
: Updated the pipeline execution logic to use the new boolean return type for determining whether to continue.setGoto
function and associated context value setting ins3Service
andscriptConfigmap
functions. [1] [2]