Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(main): fix panic for pipelines #38

Merged
merged 1 commit into from
Oct 13, 2024
Merged

feat(main): fix panic for pipelines #38

merged 1 commit into from
Oct 13, 2024

Conversation

cuisongliu
Copy link
Owner

This pull request modifies the AutoMQReconciler to change the return types of various pipeline functions from context.Context to bool, simplifying the logic for determining whether to continue the pipeline.

Changes to Return Types:

Simplification of Pipeline Logic:

  • internal/controller/automq_controller.go: Updated the pipeline execution logic to use the new boolean return type for determining whether to continue.
  • Removed the setGoto function and associated context value setting in s3Service and scriptConfigmap functions. [1] [2]

Signed-off-by: cuisongliu <cuisongliu@qq.com>
@cuisongliu cuisongliu merged commit e3457a9 into main Oct 13, 2024
6 checks passed
@cuisongliu cuisongliu deleted the fix-panic branch October 13, 2024 16:25
@github-actions github-actions bot mentioned this pull request Oct 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant