feat(main): fix helm config #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the Helm chart templates and the AutoMQ controller to enhance functionality and improve maintainability. The most important changes include adding new template functions to handle image tags and pull policies, updating deployment annotations, and cleaning up services in the AutoMQ controller.
Helm Chart Template Enhancements:
deploy/charts/automq-operator/templates/_helpers.tpl: Added functions to extract the image tag, determine the image pull policy based on the tag, and set the revision annotation. (automq-operator.getTag,automq-operator.pullPolicy,automq-operator.revision)Deployment Configuration Updates:
deploy/charts/automq-operator/templates/deployment.yaml: Updated deployment annotations to include the operator revision and modified the image pull policy to use the new template function. [1] [2]AutoMQ Controller Cleanup:
internal/controller/automq_controller_b.go: Added code to delete the bootstrap service during the broker cleanup process.