Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Should aop section link to https://github.com/cujojs/meld ? #114

Closed
skiadas opened this issue Jun 17, 2013 · 4 comments
Closed
Assignees
Milestone

Comments

@skiadas
Copy link
Contributor

skiadas commented Jun 17, 2013

The docs section on aop: docs/connections.md#aspect-oriented-programming-aop
has a fair number of examples, but for instance does not discuss 'around' advices. Would it make sense for that section to link to cujojs/meld, just as the "promise-aware aop" section links to cujojs/when ?

@briancavalier
Copy link
Member

Yeah, I think it's mostly a deficiency in the wire docs--we def need to add a section on around advice. As for linking to meld, we should probably do that, too. In some sense, though, meld is simply an implementation detail of wire's AOP.

Sounds like there are two action items here:

  1. Add docs and examples for wire's around advice.
  2. Add a link to meld, even if only for more background reading on AOP concepts, and halo effect.

@ghost ghost assigned briancavalier Jun 18, 2013
@skiadas
Copy link
Contributor Author

skiadas commented Jun 20, 2013

Hm I need to figure out how to make the pull request automatically link to an issue. Anyway, #115
Not sure the language is quite right.

@briancavalier
Copy link
Member

Thanks!

FYI: To autolink, just mention the issue number in the description body (not the title) of the PR.

@skiadas
Copy link
Contributor Author

skiadas commented Jun 20, 2013

Gotcha

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants