Adding AoP around advice examples. Fixes #114 #115
Conversation
|
Wow, @skiadas, thanks for this! I'll try to review in the next day or so. |
|
This latest commit should also fix #116 |
|
Left one comment about the around example, but otherwise this looks great. Let's work through the around advice, and then I'll get this merged. Thanks! |
|
Let's try this one. I left out proceedCount, as I didn't think it was the most critical component of "around". |
|
Looks good. Yeah, I think leaving out Thanks again for this. I'll merge it today. |
|
@briancavalier where are we with this pull request? Do I need to add/change anything? |
|
Whoops! Sorry I let this drop. Looking at it now |
|
Okay something really weird is going on. I have created a new commit which I according to my computer have pushed, and it is here: skiadas@21caf31 |
|
Hrm, not sure, but I've managed to get into (and out of, thankfully) similar situations. Sounds like you might try rebasing your branch on latest upstream master, then interactive rebasing to squash all your commits for this PR into a single commit, then force pushing that to your remote branch. Takes a little git-fu, but there are some good refs here, here, and here. Another option would be to create a new branch from Hope that helps, and keep me posted! |
Add 'around' example in wire spec example Add example of a 'around' method implementation Use destroy instead of ready in the example for destroy Updated "around" example Simplified around advice example
|
Phew, all this rebasing will take some more time to master, but I think it worked? |
|
Yeah, rebasing/squashing/force pushing is pretty radical if you've not done it before :) Once you get the hang of it, it's incredibly useful, especially for pull requests. Looking over the result, it all looks good. Thanks for working through this! |
Adding AoP around advice examples. Fixes #114
No description provided.