Project Features incl update/delete #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cvbarros
reviewed
Apr 19, 2020
There was a problem hiding this comment.
Hi @tombuildsstuff , thanks for the PR! 🎉
I've added a minor question about the introduction of a dependency - That cleared, I'll get this merged and released asap 👍
cvbarros
approved these changes
Apr 20, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes & rebases the work done by @JanBerktold in #63 - but also includes support for Updating and Deleting them
For the sake of completeness I've added a couple of update tests too, toggling most of the fields in the Project Feature to ensure they're updated