-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Breaking change in 0.1.7 #19
Comments
damn - im sorry - ill investigate as well - please report anything you find |
what db driver are you using? |
ive tested with PG and SQLite and have no issues... this is probably affecting some users: I do not have test cases around:
And in 0.1.7 they defaulted to the no-unwraping logic... which may be incorrect |
We are using PG with knex v0.16.5 |
Hmm i dont have that issue with Knex and PG - can you create a code sandbox or similar to help me debug? |
I'm also getting this error:
Going back to ver 0.1.6 fixed it. Seems that the changes to the getBatched function there are not passing the this.knex object properly into the normalizeDBResult function. |
@Igoslow Hi I think this line should be Also I found that I need to chage this line but I rewrite it for my needs. Another important thing for me, is to return parsed result from db, not raw responce from db driver(that is returned now), if this needed feature I can make pr. |
@a2exfr What DB driver are you using? |
@cvburgess I use MySQL as the DB. This is knex raw method feature. |
Awesome! Can you open a PR that adds MySQL support - the line code for driver-level editing of the raw response is here: https://github.com/cvburgess/SQLDataSource/blob/master/SQLCache.js#L22-L23 |
@jgoslow i think this may be related to your node version? Can i get more information about your env? |
Sure no problem. Node version 8.12.0
…On Mon, May 20, 2019 at 2:11 PM Charles Burgess ***@***.***> wrote:
@jgoslow <https://github.com/jgoslow> i think this may be related to your
node version? Can i get more information about your env?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=ACANBCWR42TYNNNCX3UXKFLPWMHWXA5CNFSM4HIHG3B2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV2CW3Y#issuecomment-494152559>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACANBCVNWI2DPUEZ2QZRWDDPWMHWXANCNFSM4HIHG3BQ>
.
--
*Jonas Goslow*
jonas@lyradesigns.com
*612-203-9184*
|
I've published https://github.com/cvburgess/SQLDataSource/releases/tag/v0.2.0 which should fix some of these issues and remove some magic around batching |
knex not initializing correctly, still looking into details
fyi
The text was updated successfully, but these errors were encountered: