Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support specifying a knex instance instead of config object #52

Merged
merged 3 commits into from
Apr 7, 2020
Merged

Support specifying a knex instance instead of config object #52

merged 3 commits into from
Apr 7, 2020

Conversation

theogravity
Copy link
Contributor

@theogravity theogravity commented Apr 7, 2020 •
edited
Loading

This is to address #46

This is a backwards-compatible change.

I did try to see if I could do if (knexInstance instanceof Knex), but it doesn't work.

@cvburgess cvburgess merged commit b57e2f6 into cvburgess:master Apr 7, 2020
@cvburgess
Copy link
Owner

Thank you! this should now be availble via NPM 💃

@theogravity theogravity deleted the pass-knex-instance branch April 7, 2020 20:24
@lorensr lorensr mentioned this pull request May 9, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cvburgess cvburgess cvburgess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theogravity @cvburgess