fix: propagation of cvmfs alien and local cache #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1602077
force-pushed
the
fix/cvmfs-cache-base-probagation
branch
2 times, most recently
from
94bbeba to
6e5b1ad
Compare
1602077
force-pushed
the
fix/cvmfs-cache-base-probagation
branch
from
6e5b1ad to
1f994ee
Compare
1602077
force-pushed
the
fix/cvmfs-cache-base-probagation
branch
from
b5a32f0 to
a87e019
Compare
rochaporto
reviewed
Sep 17, 2024
|
lgtm |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVMFS_CACHE_BASEandCVMFS_ALIEN_CACHEwere previously advertised as being configurable via helm values.yaml, however were hardcoded volumeMounts and hardcoded defaults in the application code.I have adjusted the config loading of the automount binary to use the values in
/etc/cvmfs/default.localif they are present and otherwise fall back on the previous hardcoded values ininternal/cvmfs/automount/automount.go.Also added a basic set of go ci (borrowed from here).
Fixes: https://gitlab.cern.ch/kubernetes/storage/cvmfs-csi/-/issues/60