Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add debug logging of authorization subject #29

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

DrDaveD
Copy link
Contributor

@DrDaveD DrDaveD commented Aug 19, 2021

This adds debug logging of x.509 proxy subjects and json web token sub claims. Debug logging for the scitokens helper wasn't working at all, and this fixes that.

Fixes #28.

@DrDaveD DrDaveD requested a review from djw8605 August 19, 2021 17:50
@djw8605
Copy link
Collaborator

djw8605 commented Aug 19, 2021

Where does SetLogAuthzDebugFile get called? By CVMFS itself?

@DrDaveD
Copy link
Contributor Author

DrDaveD commented Aug 19, 2021

Where does SetLogAuthzDebugFile get called? By CVMFS itself?

No, it's in the first line of CheckSciToken() in this PR.

@djw8605
Copy link
Collaborator

djw8605 commented Aug 19, 2021

Ok, great!

Copy link
Collaborator

@djw8605 djw8605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djw8605 djw8605 merged commit cf90afc into cvmfs-contrib:master Aug 19, 2021
@DrDaveD DrDaveD deleted the log-subjects branch August 19, 2021 19:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show proxy DN and scitokens sub in debug log
2 participants