Consider optional onRequest format hook

[gitblit]

With my custom logging, I have an onRequest hook that logs start of request processing. This is handy in the case where Elysia (or a plugin) does something unexpected and the request does not make it all the way through to onResponse. It would be convenient if there was an optional format override for onRequest, maybe by default it does nothing.

This is a hybrid of what I am using and what I'd like to have.

// exports a Logestic plugin instance
export const logger = new Logestic()
  .use(["time", "method", "path", "status", "duration"])
  .format({
    onRequest({ time, method, path }) {
      const grayTime = chalk.gray(`${time!!.toISOString()}`);
      const methodPath = chalk.cyan(`${method} ${path}`);

      return `[${grayTime}] 🟢 ${methodPath}`;
    },    
    onSuccess({ time, method, path, status, duration }) {
      const grayTime = chalk.gray(`${time!!.toISOString()}`);
      const methodPath = chalk.cyan(`${method} ${path}`);
      let statusColor = chalk.white;

      if (200 <= status && status < 300) statusColor = chalk.green;
      if (400 <= status && status < 500) statusColor = chalk.yellow;
      if (500 <= status) statusColor = chalk.red;

      const durationInMsecs = chalk.magenta(`${(duration ?? 0n) / 1000n}`);

      return `[${grayTime}] 🛑 ${methodPath} | ${statusColor(status)} | ${durationInMsecs} ms\n`;
    },
    onFailure({ request, error, code, datetime }) {
      const log = chalk.red(`[${datetime.toISOString()}]: ${request.method} ${request.url} | ERROR | ${code}`);
      return `${log}\n${error}`;
    },
  });

[cybercoder-naj]

Sounds like a reasonable addition. Will focus on it once the stable version has been released. Are there any major/minor bugs you've encountered?

[gitblit]

I did encounter a bug when first using the sample for a custom logger. Your example logs to a file. I just copied & pasted what you had and ran it. This caused errors because the destination log file did not exist, which seemed a surprising error. I didn't chase that, I just removed the destination file config.

I am liking your library very much. 👍 It's a needed option for the Elysia community.

[cybercoder-naj]

Implemented. Ready to publish

[gitblit]

Awesome! I’m away for the week but will check this out next week!

…

On Sat, Mar 30, 2024 at 4:49 PM Nishant Aanjaney Jalan < ***@***.***> wrote: Closed #13 <#13> as completed via #19 <#19>. — Reply to this email directly, view it on GitHub <#13 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGT66OG5PFNFXXVGBH4RYLY24JLZAVCNFSM6AAAAABFI5IAM6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGMYDCNZRGYYTCMA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[gitblit]

onRequest works great! Unfortunately, onSuccess breaks for me with the above customized logger with the change in 1.0.1.

[gitblit]

Reported in #20