Remove assignment by reference operator. #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason this pointer to the data of
$current_usercauses apache2 to segfault under php7.3 (see the comment on #39 (comment)).Using
&$current_userwas originally added in da3e7ccTBH, I'm not entirely sure why this causes a segfault, but I think this bug fix has something to do with it: https://www.php.net/manual/en/migration73.incompatible.php#migration73.incompatible.core.static-properties
For what its worth, I have tested logging in and out multiple times with this change under php5.6, php7.0, and php7.3 and it works just fine under each version.