Ensure dangling resources are destroyed in move-assignment operator

cycfi · Nov 20, 2023 · a8bac68 · a8bac68
1 parent f54953d
commit a8bac68
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/include/elements/support/pixmap.hpp b/lib/include/elements/support/pixmap.hpp
@@ -96,8 +96,7 @@ namespace cycfi { namespace elements
    {
       if (this != &rhs)
       {
-         _surface = rhs._surface;
-         rhs._surface = nullptr;
+        std::swap(_surface, rhs._surface);
       }
       return *this;
    }

diff --git a/lib/src/support/glyphs.cpp b/lib/src/support/glyphs.cpp
@@ -181,6 +181,13 @@ namespace cycfi { namespace elements
    {
       if (&rhs != this)
       {
+         if (_glyphs)
+            cairo_glyph_free(_glyphs);
+         if (_clusters)
+            cairo_text_cluster_free(_clusters);
+         if (_scaled_font)
+            cairo_scaled_font_destroy(_scaled_font);
+
          _first = rhs._first;
          _last = rhs._last;
          _scaled_font = rhs._scaled_font;