Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bundle grpahViz and use non root user #221

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

agalazis
Copy link
Contributor

@agalazis agalazis commented Apr 9, 2023

By not bundling grpahviz it cannot be used as a standalone tool. What I was interested in is a docker image for a pre-commit hook. With this image, I can do the following pre-commit config:

      - id: terraform-inframap
        name: terraform-inframap
        language: docker_image
        entry: --entrypoint /bin/sh agalazis/inframap
        args: ['-c' , 'for file in $(find /src -name "*.tfstate" -o -name "*.tf") ; do output=${file%%.*};  /home/inframap/inframap generate $file | dot -Tpng  > "${output}.png" ;done;']
        pass_filenames: false

Also, using root is not ideal. So I configured a user for it.

Also added entry to the CHANGELOG and updated the README with this new feature
@xescugc
Copy link
Member

xescugc commented Aug 28, 2023

Thanks @agalazis , as this is an old PR I took the liberty to fix the ENTRYPOINT and also update a few things on the README

@xescugc xescugc merged commit 052ec4b into cycloidio:master Aug 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants