Skip to content

feat: find missing files when using all:true option #208

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 7 commits into from
Apr 21, 2020
Merged

Conversation

bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Apr 21, 2020

  • closes Report all files when using all:true  #207
  • finds all files matching include, exclude if all: true (but always excluding the node_modules)
  • inserts missing files into .nyc_output/out.json file before generating reports (as placeholder objects, not real coverage)
  • confirms the results on CI

Screen Shot 2020-04-21 at 12 10 09 PM

Screen Shot 2020-04-21 at 12 18 32 PM

@bahmutov
Copy link
Contributor Author

Use in https://github.com/penx/storybook-code-coverage for #206 will show

Screen Shot 2020-04-21 at 12 51 35 PM

note: the merge reports operation could break, since I am inserting just an empty object

@bahmutov bahmutov changed the title Add all feat: find missing files when using all:true option Apr 21, 2020
@bahmutov bahmutov merged commit 2ce2d90 into master Apr 21, 2020
@bahmutov
Copy link
Contributor Author

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

rndmerle pushed a commit to rndmerle/code-coverage that referenced this pull request Apr 25, 2020
* add example where a file should not be covered

* find files to include using globby

* insert empty coverage for missed files

* refactor a little

* change the icon for files without any statements

* confirm file not-covered is present in the final report

* search using default extension masks if include is not present
@DenrizSusam
Copy link

Is there a way to get correct coverage statistic?
(for example: for this report I want to see correct line coverage which also includes ones that are not covered

image
)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report all files when using all:true
2 participants