Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add experimentalFetchPolyfill docs #2881

Merged
merged 3 commits into from
Jun 15, 2020
Merged

Add experimentalFetchPolyfill docs #2881

merged 3 commits into from
Jun 15, 2020

Conversation

bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Jun 12, 2020

updated places where we talk about network stubbing and warn about window.fetch

Used Markdown URL in the partial, because using {% URL ... %} was throwing an error

TypeError: Cannot read property 'data' of undefined
    at Object.getUrlProps (/Users/gleb/git/cypress-documentation/lib/tags/url.js:6:29)
    at /Users/gleb/git/cypress-documentation/lib/tags/url.js:88:24
    at tryCatcher (/Users/gleb/git/cypress-documentation/node_modules/bluebird/js/release/util.js:16:23)

for cypress-io/cypress#7597

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah url tags don't work in partials #2422

@bahmutov bahmutov marked this pull request as ready for review June 15, 2020 15:34
@bahmutov bahmutov changed the base branch from develop to 4.8.1 June 15, 2020 15:35
@bahmutov bahmutov merged commit 3744db4 into 4.8.1 Jun 15, 2020
@jennifer-shehane jennifer-shehane mentioned this pull request Jun 16, 2020
jennifer-shehane added a commit that referenced this pull request Jun 16, 2020
Co-authored-by: Gleb Bahmutov <gleb.bahmutov@gmail.com>
@matthamil matthamil deleted the fetch-polyfill branch April 14, 2021 19:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants