add new blogs w/img #673
Merged
add new blogs w/img #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
img for e2e with Selenium and Cypress
e2e with Selenium and Cypress
testing react apps with cypress
testing react apps with cypress
start your end to end testing with angular and cypress
start end to end testing with angular and cypress
jennifer-shehane
approved these changes
Jun 5, 2018
jennifer-shehane
requested changes
Jun 5, 2018
source/_data/blogs.yml
Outdated
| sourceUrl: https://offering.solutions/blog/ | ||
| date: May 27, 2018 | ||
| author: Fabian Gosebrink | ||
| img: /img/examples/e2e-with-angular-and-cypress.jgp |
There was a problem hiding this comment.
Did you run this locally to ensure all of the images work correctly? I notice this has a .jgp extension, which does not look correct. You'll need to always run it locally and ensure the images and links are working.
There was a problem hiding this comment.
Good catch. Funny thing is, I did and always do run it locally. And the incorrect file extension did work. 🤷🏻♀️
Will fix.
There was a problem hiding this comment.
Closer inspection reveals that the image extension is misspelled as well. So I guess that's why it worked. D'oh.
replaced image with .jpg file extension
change .jgp to .jpg
jennifer-shehane
approved these changes
Jun 5, 2018
Merged
brian-mann
pushed a commit
that referenced
this pull request
Jun 7, 2018
* add new blogs w/img (#673) * add blog img img for e2e with Selenium and Cypress * add new blog e2e with Selenium and Cypress * add new blog testing react apps with cypress * add blog img testing react apps with cypress * add blog img start your end to end testing with angular and cypress * add new blog start end to end testing with angular and cypress * delete image with incorrect file extension * new blog img replaced image with .jpg file extension * rename file extension change .jgp to .jpg * Add PR template [skip ci] * add html example to .not assertion (#678) * update ci docs (#679) * chore(deps): Update sinon to 5.1.0 🌟 (#680) * chore(deps): update nock to 9.3.1 🌟 (#683) * add quotes around --spec arg (#686) * update ci docs
jennifer-shehane
added a commit
that referenced
this pull request
Jun 8, 2018
* add new blogs w/img (#673) * add blog img img for e2e with Selenium and Cypress * add new blog e2e with Selenium and Cypress * add new blog testing react apps with cypress * add blog img testing react apps with cypress * add blog img start your end to end testing with angular and cypress * add new blog start end to end testing with angular and cypress * delete image with incorrect file extension * new blog img replaced image with .jpg file extension * rename file extension change .jgp to .jpg * Add PR template [skip ci] * add html example to .not assertion (#678) * update ci docs (#679) * chore(deps): Update sinon to 5.1.0 🌟 (#680) * chore(deps): update nock to 9.3.1 🌟 (#683) * add quotes around --spec arg (#686) * update ci docs * chore(deps): update nock to 9.3.2 🌟 (#684)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created new branch, old branch has package-lock.json conflicts