Skip to content

Commit

Permalink
misc: allow HiDPI Screen running wayland to use cypress window/browser (
Browse files Browse the repository at this point in the history
#29366)

* misc: allow HiDPI Screen running wayland to use cypress window/browser

* Added changelog entry

* Fix changelog entry release date to pending

* Changed release changelog entry to actual date

* Added issue number to the changelog entry

* fix tests

* update changelog

---------

Co-authored-by: Ryan Manuel <ryanm@cypress.io>
  • Loading branch information
Azvya Erstevan and ryanthemanuel authored Aug 13, 2024
1 parent 0772844 commit c20b242
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions cli/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ _Released 8/13/2024 (PENDING)_
**Misc:**

- Updated `cypress open` hints displayed after Cypress binary install. Addresses [#29935](https://github.com/cypress-io/cypress/issues/29935).
- Allow HiDPI Screen running wayland to use cypress window/browser by adding `--ozone-platform=auto` flag to the electron's runtime argument. Addresses [#20891](https://github.com/cypress-io/cypress/issues/20891).

## 13.13.2

Expand Down
2 changes: 1 addition & 1 deletion cli/lib/exec/spawn.js
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ module.exports = {

const { onStderrData } = overrides
const envOverrides = util.getEnvOverrides(options)
const electronArgs = []
const electronArgs = ['--ozone-platform=auto']
const node11WindowsFix = isPlatform('win32')

let startScriptPath
Expand Down
4 changes: 4 additions & 0 deletions cli/test/lib/exec/spawn_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ describe('lib/exec/spawn', function () {
return spawn.start('--foo', { foo: 'bar' })
.then(() => {
expect(cp.spawn).to.be.calledWithMatch('/path/to/cypress', [
'--ozone-platform=auto',
'--',
'--foo',
'--cwd',
Expand Down Expand Up @@ -148,6 +149,7 @@ describe('lib/exec/spawn', function () {
const args = cp.spawn.firstCall.args.slice(0, 2)
// it is important for "--no-sandbox" to appear before "--" separator
const expectedCliArgs = [
'--ozone-platform=auto',
'--no-sandbox',
'--',
'--foo',
Expand All @@ -173,6 +175,7 @@ describe('lib/exec/spawn', function () {
.then(() => {
expect(cp.spawn).to.be.calledWithMatch('node', [
p,
'--ozone-platform=auto',
'--',
'--foo',
'--cwd',
Expand All @@ -198,6 +201,7 @@ describe('lib/exec/spawn', function () {
.then(() => {
expect(cp.spawn).to.be.calledWithMatch('node', [
p,
'--ozone-platform=auto',
'--',
'--foo',
'--cwd',
Expand Down

2 comments on commit c20b242

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on c20b242 Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.13.3/darwin-arm64/develop-c20b242ac63202a8b6fd62334eb8024c0a173321/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on c20b242 Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.13.3/win32-x64/develop-c20b242ac63202a8b6fd62334eb8024c0a173321/cypress.tgz

Please # to comment.