Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: enable contextIsolation by default in Electron #15493

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Mar 15, 2021

  • Closes

User facing changelog

Additional details

  • This became the default with Electron 12, we should follow the defaults as closely as possible.
  • Users can override using before:browser:launch API
  • internal change: contextBridge.exposeInMainWorld must now be used to expose preload APIs, but this only affects the ipc object used by desktop-gui, so it should not affect users: https://www.electronjs.org/docs/tutorial/context-isolation

How has the user experience changed?

PR Tasks

  • [na] Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 15, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Mar 15, 2021



Test summary

553 0 0 0


Run details

Project cypress
Status Passed
Commit c4ffb3a
Started Mar 15, 2021 11:19 PM
Ended Mar 15, 2021 11:28 PM
Duration 08:34 💡
OS Linux Debian - 10.8
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig requested a review from chrisbreiding March 16, 2021 15:26
@flotwig flotwig merged commit fdcf482 into 7.0-release Mar 17, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 5, 2021

Released in 7.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 5, 2021
@flotwig flotwig deleted the enable-contextIsolation branch January 24, 2022 18:20
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants