fix: revert dynamic import of webpack config file #24598
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
This PR reverts the change made to
webpack-dev-server
for how we are loading the sourcedwebpack.config.{js,ts}
. Previously it was usingloadModule
which is basically a require. We changed it to use a dynamic import but this no longer works when doingawait import('{project-root}/webpack.config.ts')
as ts-node does not process the typescript webpack config file.No user-facing change as the dynamic import was never published.
Steps to test
On develop, run
yarn cypress:open
and choose an app that has awebpack.config.ts
and does not specify it in thecypress.config.ts
. svelte-webpack-ts is a good example. This will fail.Checkout this branch and run
yarn
. Run the same steps above and the app will load.How has the user experience changed?
Screen.Recording.2022-11-08.at.11.27.08.AM.mov
PR Tasks
cypress-documentation
?type definitions
?