-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: increases windows resourcing #28494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cacieprins I think you put the wrong branch on the windows CI PR in the circle workflow, which is why it wasn’t running all the workflows. Should be cacie/chore/inc-windows-resourcing |
@cacieprins It doesn't seem like the unit tests, v8 integration tests, or windows-driver-integration-memory-tests require more resources, you could maybe even bump it down to medium to offset some cost:
![]() |
emilyrohrbough
approved these changes
Dec 19, 2023
chrisbreiding
approved these changes
Dec 19, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Increases certain windows executors to xlarge, with the goal of increasing CI pass rate
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?