Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: increases windows resourcing #28494

Merged
merged 7 commits into from
Dec 19, 2023

Conversation

cacieprins
Copy link
Contributor

  • Closes

Additional details

Increases certain windows executors to xlarge, with the goal of increasing CI pass rate

Steps to test

How has the user experience changed?

PR Tasks

@cacieprins cacieprins marked this pull request as ready for review December 11, 2023 15:31
Copy link

cypress bot commented Dec 11, 2023

87 failed and 4 flaky tests on run #52824 ↗︎

87 395 7 1 Flakiness 4

Details:

reduce some windows resourcing to medium
Project: cypress Commit: 77eebec017
Status: Failed Duration: 12:05 💡
Started: Dec 14, 2023 9:30 PM Ended: Dec 14, 2023 9:42 PM
Failed  cypress\e2e\runs.cy.ts • 34 failed tests • app-e2e

View Output

Test Artifacts
App: Runs > Runs Page > resolves the runs page Test Replay Screenshots
App: Runs > Runs Page > shows the loader Test Replay Screenshots
App: Runs > Runs - Login > when logged out, shows call to action Test Replay Screenshots
App: Runs > Runs - Login > clicking the login button will open the login modal Test Replay Screenshots
App: Runs > Runs - Login > if logged in and connected Test Replay Screenshots
App: Runs > Runs - Connect Org > opens create Org modal after clicking Connect Project button Test Replay Screenshots
App: Runs > Runs - Connect Org > opens create Org modal after clicking Connect Project button and refetch data from the cloud Test Replay Screenshots
App: Runs > Runs - Connect Org > refetches cloudViewer data on open Test Replay Screenshots
App: Runs > Runs - Connect Project > opens Connect Project modal after clicking Connect Project button Test Replay Screenshots
App: Runs > Runs - Connect Project > shows "Connect project" button if a project is not connected after login Test Replay Screenshots
The first 10 failed tests are shown, see all 34 tests in Cypress Cloud.
Failed  cypress\e2e\runner\reporter.hooks.cy.ts • 5 failed tests • app-e2e

View Output

Test Artifacts
hooks > displays commands under correct hook Test Replay Screenshots
hooks > creates open in IDE button Test Replay Screenshots
hooks > does not display commands from skipped tests Test Replay Screenshots
hooks > only displays tests with .only Test Replay Screenshots
hooks > can rerun without timeout error leaking into next run (due to run restart) Test Replay Screenshots
Failed  cypress\e2e\runner\reporter-ct-webpack.errors.cy.ts • 18 failed tests • app-e2e

View Output

Test Artifacts
Webpack - errors ui > assertion failures Test Replay Screenshots
Webpack - errors ui > assertion failures - no preferred IDE Test Replay Screenshots
Webpack - errors ui > exception failures Test Replay Screenshots
Webpack - errors ui > hooks Test Replay Screenshots
Webpack - errors ui > commands Test Replay Screenshots
Webpack - errors ui > cy.then Test Replay Screenshots
Webpack - errors ui > cy.should Test Replay Screenshots
Webpack - errors ui > cy.each Test Replay Screenshots
Webpack - errors ui > cy.spread Test Replay Screenshots
Webpack - errors ui > cy.within Test Replay Screenshots
The first 10 failed tests are shown, see all 18 tests in Cypress Cloud.
Failed  cypress\e2e\runner\reporter-ct-vite.errors.cy.ts • 17 failed tests • app-e2e

View Output

Test Artifacts
Vite - errors ui > assertion failures Test Replay Screenshots
Vite - errors ui > assertion failures - no preferred IDE Test Replay Screenshots
Vite - errors ui > hooks Test Replay Screenshots
Vite - errors ui > commands Test Replay Screenshots
Vite - errors ui > cy.then Test Replay Screenshots
Vite - errors ui > cy.should Test Replay Screenshots
Vite - errors ui > cy.each Test Replay Screenshots
Vite - errors ui > cy.spread Test Replay Screenshots
Vite - errors ui > cy.within Test Replay Screenshots
Vite - errors ui > cy.wrap Test Replay Screenshots
The first 10 failed tests are shown, see all 17 tests in Cypress Cloud.
Failed  cypress\e2e\runner\reporter.command_errors.cy.ts • 13 failed tests • app-e2e

View Output

Test Artifacts
errors ui > assertion failures Test Replay Screenshots
errors ui > assertion failures - no preferred IDE Test Replay Screenshots
errors ui > cy.then Test Replay Screenshots
errors ui > cy.should Test Replay Screenshots
errors ui > cy.each Test Replay Screenshots
errors ui > cy.spread Test Replay Screenshots
errors ui > cy.within Test Replay Screenshots
errors ui > cy.wrap Test Replay Screenshots
errors ui > cy.visit Test Replay Screenshots
errors ui > cy.intercept Test Replay Screenshots
The first 10 failed tests are shown, see all 13 tests in Cypress Cloud.

The first 5 failed specs are shown, see all 48 specs in Cypress Cloud.

Flakiness  cypress\e2e\cypress-in-cypress.cy.ts • 1 flaky test • app-e2e

View Output

Test Artifacts
Cypress in Cypress > restarts browser if there is a before:browser:launch task and there is a change on the config Test Replay Screenshots
Flakiness  cypress\e2e\migration.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test Artifacts
Full migration flow for each project > migration-e2e-component-default-test-files > skips the file renaming Test Replay Screenshots
Flakiness  cypress\e2e\scaffold-component-testing.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test Artifacts
scaffolding component testing > react-vite-ts-unconfigured > scaffolds component testing for React and Vite Test Replay Screenshots
Flakiness  cypress\e2e\project-setup.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test Artifacts
... > can reconfigure config after CT has been set up Test Replay Screenshots

Review all test suite changes for PR #28494 ↗︎

@jennifer-shehane
Copy link
Member

@cacieprins I think you put the wrong branch on the windows CI PR in the circle workflow, which is why it wasn’t running all the workflows. Should be cacie/chore/inc-windows-resourcing

@jennifer-shehane
Copy link
Member

@cacieprins It doesn't seem like the unit tests, v8 integration tests, or windows-driver-integration-memory-tests require more resources, you could maybe even bump it down to medium to offset some cost:

Screen Shot 2023-12-14 at 1 01 29 PM

@jennifer-shehane jennifer-shehane merged commit 9c46519 into develop Dec 19, 2023
@jennifer-shehane jennifer-shehane deleted the cacie/chore/inc-windows-resourcing branch December 19, 2023 14:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants