Upgrade to Chai 4 #2862
Merged
Upgrade to Chai 4 #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lilaconlee
commented
Nov 30, 2018
•
lilaconlee
commented
- Fixes Upgrade chai to latest version #2529
- Fixes 'Nested' assertions not working in 3.4.1 #5004
- Fixed Can't invoke "nested" when making expectations #5350
31 tasks
lilaconlee
commented
Dec 5, 2018
| args = if subject?._spreadArray then args else [args] | ||
|
|
||
| try | ||
| hasSpreadArray = "_spreadArray" in subject or subject?._spreadArray |
There was a problem hiding this comment.
This works for proxies or regular objects, but I don't love it. Would love any ideas for alternatives!
chrisbreiding
pushed a commit
that referenced
this pull request
May 21, 2019
* Initial upgrade changes * Some quick fixes * More fixes * Clean up exp logic and fix spread array failures * Remove caret from package.json * Add handling for proxies in isJquery * iterate on flaky test, increase default command timeout
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.