chore: Add experimentalMemoryManagement flag to our cy-in-cy App tests #29359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-675
to
-677
| if [[ <<parameters.package>> == 'app' && <<parameters.type>> == 'e2e' ]]; then | ||
| export DEBUG=cypress:* | ||
| fi |
There was a problem hiding this comment.
Removed these DEBUG flag from windows because I couldn't see if the errors were legitimate or not with the debug on (they were not)
AtofStryker
approved these changes
Apr 22, 2024
mschile
approved these changes
Apr 22, 2024
|
Merging with windows flake - this is known on the project-setup: https://cloud.cypress.io/projects/ypt4pf/runs/55073/overview/7b5ffde2-f041-47a5-8c8d-348562df0b39/replay?roarHideRunsWithDiffGroupsAndTags=1&ts=1713806090740.454&att=1 |
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #29357
Additional details
This PR sets
experimentalMemoryManagementtotruefor our internal app tests. Our internal App tests run cypress within cypress, which is a unique situation that our users don't encounter. The memory used in Chrome was causing this job to crash Chrome frequently.I don't see a large increase in the time to run these tests, maybe an increase of ~20-30 secs in linux and windows. I suspect they'll be more stable though.
Additionally, this PR upgrades the resource class used to run
run-app-integration-tests-chromejob to large from medium. The medium resource class was always maxing out at 100% CPU.Before
https://app.circleci.com/pipelines/github/cypress-io/cypress/61043/workflows/b0bfd961-3476-4450-9916-36d299560584/jobs/2538781/resources
After
https://app.circleci.com/pipelines/github/cypress-io/cypress/61054/workflows/fe25bb31-be6e-46b8-95ce-3bd72d1ea068/jobs/2538662/resources
Steps to test
Tests should pass. I also ran this on Windows jobs.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?