feat: install win32-x64 binary on win32-arm64 platform #31784
Conversation
|
|
It does not look like any of the CI failures are caused by the PR itself. They are more in the category of general flake. The full functionality of Cypress running under Windows on Arm can't actually be tested at this time, because CircleCI does not offer any Windows arm64 runner. So all that is being tested here is that it doesn't break anything else! |
There was a problem hiding this comment.
Everything looks good. I would like to add a github action similar to https://github.com/MikeMcC399/cypress-example-kitchensink/actions/runs/15362085426/job/43230503231 here so we have some type of test even if we cannot test it in circleCI. I might have to add that after merge though @MikeMcC399 as I would imagine it is difficult to run as a contributor.
approving the CI build to continue running
Good to hear your positive reaction!
This seems like it would be a significant effort and it would not be in line with the rest of the Cypress' CI process using CircleCI. I didn't include anything like this in the PR for that reason and I would hold off investing effort into this at the moment. Also the GitHub partner runner image windows-11-arm has the following issues:
This is not representative of current Windows 11 laptops based on Snapdragon X processors. It does not allow testing of Prism emulation that was introduced in Windows 11 24H2. Prism would be what laptop users would be using. My suggestion is to release as-is and document it as being "preview status" level support (see PR cypress-io/cypress-documentation#6193). I would expect that those users in #30252 who have expressed a need, will take it for a spin.
After release, I can update testing in https://github.com/MikeMcC399/cypress-example-kitchensink and provide feedback. I would expect everything to work based on testing so far. With some experience in the field and the prospect of an updated GitHub windows-11-arm runner image in a few weeks, the support and testing situation could be revisited. The incentive for this PR is that all major laptop vendors have Windows 11 Pro 64 ARM in their portfolio marketed under "Copilot+ PC". For example:
Again, the CircleCI failures can only be due to general flake, as there is no change made that would affect these tests. I suggest to re-run from failed. |
|
For official Microsoft compatibility support there is a special program That would however need to be driven by the Cypress.io team itself. That's not something that I could pick up. |
I think the core issue that it isn't representative of the current arm64 windows laptops. Otherwise, I think we would be OK with deviating from the current CircleCI pattern in order to get some type of test coverage. But since it isn't, the juice isn't likely worth the squeeze. Thank you for clarifying that!
That sounds like a solid plan to me!
Correct. We are on the same page here. I'll make sure we get a green run and merge it in. |
follow-on fix for PR cypress-io#31784
* chore: fix pre-release download for win32-arm64 follow-on fix for PR #31784 * add unit test win32-arm64 to win32-x64 for pre-release
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
Attempting to install Cypress on a Windows
arm64system (aka WoA - Windows on Arm) causes Cypress to abort the installation and output the error message:Cypress does not build a binary for the Microsoft Windows
arm64architecture (win32-arm64), however Windows Arm-based PCs offers emulation forwin32-x64apps. The availablex64emulation functionality of Windows has so far not been used by Cypress.To enable installation of the Cypress
win32-x64binary on Windowsarm64systems, opening up the possibility for Windows on Arm to provide its emulation capabilities to Cypress, two changes are made:arm64is detected, then the download is changed to use the Cypress Windowsx64binary (win32-x64) instead.win32-arm64.Steps to test
Previously tested as a patch in https://github.com/MikeMcC399/cypress-example-kitchensink/tree/use/windows-11-arm using workflow .github/workflows/chrome.yml.
Testable in branch
windows-11-arm-betausing workflow .github/workflows/chrome.yml as soon as a beta binary build is available... both using Windows 11 arm image (
windows-11-arm) currently in public preview.CircleCI does not currently offer a Windows arm platform for CI testing.
How has the user experience changed?
With this PR, users of Arm-based Windows PCs can install and run Cypress in the same way they would on an amd64-based Windows PC.
PR Tasks
cypress-documentation? Add Windows 11 24H2 arm64 support cypress-documentation#6193type definitions?