Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not crash if onBeforeLog returns false #958

Closed
wants to merge 2 commits into from
Closed

Do not crash if onBeforeLog returns false #958

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e29dc9
return a log object even if onBeforeLog is false
derfred Nov 24, 2017
4c91b22
Merge branch 'develop' into always_return_a_log_object
jennifer-shehane Nov 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/driver/src/cypress/log.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ create = (Cypress, cy, state, config) ->
## dont trigger log if this function
## explicitly returns false
if _.isFunction(onBeforeLog)
return if onBeforeLog.call(cy, log) is false
return log if onBeforeLog.call(cy, log) is false

## set the log on the command
state("current")?.log(log)
Expand Down