Fix centerlineLength function by updating previous_pair, add tests for this and riverWidthFromCenterline #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r this and riverWidthFromCenterline
|
Ha, nice catch! Thanks for the help |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
centerlineLengthfunction we were never updating previous_pair, which meant we were calculating distances from the initial point rather than intermediate point.Add tests for this and the
riverWidthFromCenterlinefunction.Also some minor doc updates to the
README.mdfile, one of which to clarify the return values of theriverWidthFromCenterlinefunction.