This repository has been archived by the owner on Sep 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Configure CentOS to disregard previously configured NTP servers in ntp.conf when using DHCP-provided NTP servers #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with CentOS and Ubuntu instances on atmobeta, produces intended result, removing WIP label. |
cdosborn
reviewed
May 14, 2018
owner: 'root' | ||
mode: 'u=rwx,g=rx,o=rx' | ||
with_first_found: | ||
- '{{ ansible_distribution }}-{{ ansible_distribution_major_version}}.ntp.sh.j2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for future proofing, with_first_found
should include a default, or skip=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! Tested and pushed another commit to skip if no template found.
cdosborn
approved these changes
May 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for getting this fix out.
Mind adding an entry to the change log? |
You betcha. see latest commit |
…p.conf when using DHCP-provided NTP servers
ee65a32
to
1dfd7ef
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See JETSTREAM-22
Checklist before merging Pull Requests