Skip to content
This repository has been archived by the owner on Sep 12, 2022. It is now read-only.

Configure CentOS to disregard previously configured NTP servers in ntp.conf when using DHCP-provided NTP servers #146

Merged
merged 5 commits into from
May 14, 2018

Conversation

c-mart
Copy link
Contributor

@c-mart c-mart commented May 9, 2018

Description

See JETSTREAM-22

Checklist before merging Pull Requests

  • New test(s) included to reproduce the bug/verify the feature
  • Add an entry in the changelog
  • Documentation created/updated (include links)
  • Reviewed and approved by at least one other contributor.
  • New variables contributed to atmosphere/Clank

@c-mart c-mart changed the title WIP: Configure CentOS to disregard previously configured NTP servers in ntp.conf when using DHCP-provided NTP servers Configure CentOS to disregard previously configured NTP servers in ntp.conf when using DHCP-provided NTP servers May 10, 2018
@c-mart
Copy link
Contributor Author

c-mart commented May 10, 2018

Tested with CentOS and Ubuntu instances on atmobeta, produces intended result, removing WIP label.

owner: 'root'
mode: 'u=rwx,g=rx,o=rx'
with_first_found:
- '{{ ansible_distribution }}-{{ ansible_distribution_major_version}}.ntp.sh.j2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future proofing, with_first_found should include a default, or skip=true

Copy link
Contributor Author

@c-mart c-mart May 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Tested and pushed another commit to skip if no template found.

Copy link
Contributor

@cdosborn cdosborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for getting this fix out.

@cdosborn
Copy link
Contributor

Mind adding an entry to the change log?

@c-mart
Copy link
Contributor Author

c-mart commented May 14, 2018

You betcha. see latest commit

@cdosborn cdosborn self-assigned this May 14, 2018
@cdosborn cdosborn force-pushed the jetstream-22 branch 2 times, most recently from ee65a32 to 1dfd7ef Compare May 14, 2018 19:18
@cdosborn cdosborn merged commit ecf234a into cyverse:master May 14, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants