[Issue #38] RISC-V csrd rework #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging, I think the selection is OK for now (we can fine tune it based on feedback from next semester labs). |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reworked the
csrdcommand to dump only selected CSRs.I've also implemented a new subcommand feature for
csrd- you can specify a subcommand instead of the CSR name/number which prints out a subset of CSRs.The implemented subcommands are:
mmode: prints all M-mode CSRssmode: prints all S-mode CSRscounters: prints all counter and counter setup CSRsall: prints all CSRsThe
csrdcommand without any parameter now dumps the following CSRs:A discussion about the included CSRs is welcome, I've chosen them arbitrarily by removing the counters, configuration and debug CSRs.
Note that this PR follows PR #60.