This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
records: Find user's home directory through env #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in golang/go#6376, `os/user.Current` doesn't work with cross-compilation. This commit replaces its use with `os.Getenv` of the `$HOME` and `$USERPROFILE` environment variables. Fixes #275
| usr, err := user.Current() | ||
| if err != nil { | ||
| // this can happen (on Linux) if you're running mesos-dns as a non-root user. | ||
| logging.Error.Println("Failed to determine current user, translating ~/ to ./, error was", err) |
There was a problem hiding this comment.
We don't log this anymore when HOME and USERPROFILE is unset.
There was a problem hiding this comment.
Hm, OK, this gives users some insight in those conditions. I'll add it back.
tsenart
added a commit
that referenced
this pull request
Sep 23, 2015
records: Find user's home directory through env
|
Oops. Forgot to add that log line back. I'll open a small PR for that. |
Merged
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in golang/go#6376,
os/user.Currentdoesn't work with cross-compilation.This commit replaces its use with
os.Getenvof the$HOMEand$USERPROFILEenvironment variables.Fixes #275