This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
exchanger: Improve ErrorLogging #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsenart
force-pushed
the
exchanger-better-error-logs
branch
from
5b7c99e to
442000b
Compare
| @@ -61,7 +61,7 @@ func ErrorLogging(l *log.Logger) Decorator { | |||
| return Func(func(m *dns.Msg, a string) (r *dns.Msg, rtt time.Duration, err error) { | |||
| defer func() { | |||
| if err != nil { | |||
| l.Printf("error exchanging with %q: %v", a, err) | |||
| l.Printf("error exchanging %v with %q: %v", m.Question[0], a, err) | |||
There was a problem hiding this comment.
m.Question is always non-nil and len(m)>1?
There was a problem hiding this comment.
Good catch, we may have no question, but it will never be nil.
tsenart
force-pushed
the
exchanger-better-error-logs
branch
from
442000b to
cdccd03
Compare
tsenart
added a commit
that referenced
this pull request
Oct 6, 2015
exchanger: Improve ErrorLogging
Merged
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging #297 and #298, it became apparent that this extra
information would be very useful in aiding understanding of the issue.