Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Only orphan mouse gestures. #70

Merged
merged 1 commit into from
May 15, 2020
Merged

Only orphan mouse gestures. #70

merged 1 commit into from
May 15, 2020

Conversation

mbostock
Copy link
Member

This avoids orphaning a programmatic brush transition.

Related #18.

@mbostock
Only orphan mouse gestures.
10ea210 
This avoids orphaning a programmatic brush transition.
@mbostock mbostock requested a review from Fil May 12, 2020 20:15
Fil
Fil approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@Fil Fil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well—thanks!

Can we clarify that clean means "triggered by user w/ mousedown or touchstart", vs. "programmatically via brush.move"?

@Fil Fil merged commit 1159f87 into master May 15, 2020
@Fil Fil mentioned this pull request May 15, 2020
Closed
@Fil Fil deleted the orphan-mouse branch May 15, 2020 13:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Fil Fil Fil approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbostock @Fil