Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: 🐛 Update nanoid to 3.3.8 #130

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

SpikePuppet
Copy link
Contributor

Hello! The current company I work at who uses this package has flagged that there is a vulnerability in nanoid, specifically:

nanoid (aka Nano ID) before 5.0.9 mishandles non-integer values. 3.3.8 is also a fixed version.

I've updated this package to the closest version possible with the fix in it. Hoping we can get this merged quickly so we can update this.

@d4rkr00t
Copy link
Owner

Awesome!

But it doesn't pass type checking.

Screenshot 2024-12-14 at 2 17 27 PM

@SpikePuppet
Copy link
Contributor Author

Darn, I'll tackle this ASAP!

@SpikePuppet SpikePuppet force-pushed the update-nanoid-to-3-3-8 branch from 4bd913a to 9904df5 Compare January 6, 2025 10:42
@SpikePuppet
Copy link
Contributor Author

I've managed to pull this down, run all tests and compile it. Here's hoping that it works, though please feel free to knock it back again.

@d4rkr00t d4rkr00t merged commit d07f4fc into d4rkr00t:master Jan 8, 2025
2 checks passed
@d4rkr00t
Copy link
Owner

d4rkr00t commented Jan 8, 2025

Thank you! Merged :)

@d4rkr00t
Copy link
Owner

d4rkr00t commented Jan 8, 2025

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants