KNXD USB auto select device

[burgerkingorama]

KNXD can automatically select the appropriate USB device.

The add-on configuration currently requires selecting a USB device manually.

It seems this setting was intended to be optional, as the config.yaml file includes:

device: "device?"

According to the Add-on Development Guide, you should not provide a default option if the setting is intended to be optional.

I'm happy to assist in testing a solution if you can provide guidance.

[da-anda]

there is no default device defined. The "optional" feature seems to be broken for device options in UI mode (has been the case since I created the add-on)

[burgerkingorama]

There is a default value defined:

options:
address: "0.0.1"
client_address: "0.0.2:8"
interface: usb
device: ""
log_error_level: warning
usb_filters: single
ip_address: ""
dest_port: "99"
custom_config: ""

[da-anda]

but the value is empty, and at least back in the days when I created the add-on HA complained about a broken config file if I did not add the empty string "". But just tested it locally defining it as device: and not device: "" and this seems to be working now. Thanks for the heads up - will change it.

[burgerkingorama]

The config editor is just fine now, but when starting the service the following message occures.

From the dev-guilde I would interpret, if you want to have a truly optional config, you must not define the complete line in the options dictionary (see not_need: "str?"in their sample).

[da-anda]

if I do that, the setting vanishes entirely from the UI. So I suspect this is then still a bug which needs to be reported to HA

[da-anda]

ah wait, it is there but hidden unless you switch the toggle to show unused settings. Likely not the most user friendly thing then

[da-anda]

but I still consider this to be a bug in HA

[da-anda]

once my local version updated so that I can test the latest change to the config, I will push it to github, but I won't make a new release just for this (as nothing inside the container changes). But once the commit is on github you should be able to "update" by simply uninstalling and reinstalling the add-on (maybe do a "check for updates" after uninstalling so that HA is updating the repo). After that you should have the latest config version as well

[burgerkingorama]

Now the container starts but knxd fails to start:

[21:48:27] FATAL: A device needs to be configured

[da-anda]

the reason is this check in the config script: https://github.com/da-anda/hass-io-addons/blob/main/knxd/rootfs/etc/s6-overlay/s6-rc.d/init-knxd-config/run#L30
it now would have to be adjusted to only require a device for the interface types that actually require one, but I don't have the time to do this anymore (going on vacation in 8 days and still have tons of way more important things to finish). If you have the skills, feel free to create a PR addressing this, thanks.

[da-anda]

sorry, pasted the wrong line earlier (fixed now). Actually, USB should not require a value according to the script, but I suspect the condition for this check is wrong (the check for USB would have to be negated as well, but can't think straight yet, too early)

[burgerkingorama]

Thanks, I'll take a look into the script.

In the meantime I just configure /dev/null as the device, so the script can't get the USB bus id and is left empty. Auto select works.