Skip to content

Commit 5092307

Browse files
authored
Re-enable TCG (#210)
google/tcmalloc#179 and google/tcmalloc#155 are now fixed.
1 parent 7278401 commit 5092307

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

.github/workflows/all.yml

+2-4
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,10 @@ jobs:
5252
# lf: crashes redis server
5353
# ff: crashes on modern ubuntu: https://github.com/bwickman97/ffmalloc/issues/5
5454
# hoard: crashes on rocksdb
55-
# tcg: https://github.com/google/tcmalloc/issues/155
5655
# pa: python3: can't open file '/__w/mimalloc-bench/mimalloc-bench/extern/pa/partition_alloc_builder/tools/rust/update_rust.py': [Errno 2] No such file or directory
5756
# sn: /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/chrono:2320:48: error: call to consteval function 'std::chrono::hh_mm_ss::_S_fractional_width' is not a constant expression
5857
# lp: /home/runner/work/mimalloc-bench/mimalloc-bench/extern/lp/Source/bmalloc/libpas/src/libpas/hotbit_heap_inlines.h:64:51: error: too few arguments to function call, expected 3, have 2
59-
run: ./build-bench-env.sh all no-lean no-gd no-ff no-fg no-lt no-lf no-hd no-tcg no-pa no-sn no-lp
58+
run: ./build-bench-env.sh all no-lean no-gd no-ff no-fg no-lt no-lf no-hd no-pa no-sn no-lp
6059
- name: Run everything.
6160
run: |
6261
cd out/bench
@@ -83,8 +82,7 @@ jobs:
8382
# fg: crashes redis server
8483
# pa: python3: can't open file '/__w/mimalloc-bench/mimalloc-bench/extern/pa/partition_alloc_builder/tools/rust/update_rust.py': [Errno 2] No such file or directory
8584
# lp: /__w/mimalloc-bench/mimalloc-bench/extern/lp/Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c:218:22: error: call to undeclared function 'pthread_getname_np'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
86-
# tcg: https://github.com/google/tcmalloc/issues/179
87-
run: ./build-bench-env.sh all no-lean no-mi no-mesh no-nomesh no-gd no-rp no-lf no-fg no-pa no-lp no-tcg
85+
run: ./build-bench-env.sh all no-lean no-mi no-mesh no-nomesh no-gd no-rp no-lf no-fg no-pa no-lp no-sh8
8886
- name: Run everything.
8987
run: |
9088
cd out/bench

README.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,8 @@ benchmarks as it faulted on those)
243243
- [Minor performances improvement](https://github.com/struct/isoalloc/commit/049c12e4c2ad5c21a768f7f3873d84bf1106646a) in isoalloc
244244
- [Parallel compilation](https://github.com/emeryberger/DieHard/issues/15) support in DieHarder
245245
- [Portability improvement](https://github.com/oneapi-src/oneTBB/pull/764) in Intel TBB malloc
246-
- [Various](https://github.com/google/tcmalloc/issues/155) [portability](https://github.com/google/tcmalloc/issues/128) [improvements]( https://github.com/google/tcmalloc/issues/125 ) in Google's tcmalloc
246+
- [Various](https://github.com/google/tcmalloc/issues/155) [portability](https://github.com/google/tcmalloc/issues/128)
247+
[improvements]( https://github.com/google/tcmalloc/issues/125 ) [in](https://github.com/google/tcmalloc/issues/179) Google's tcmalloc
247248
- [Improved double-free detection]( https://github.com/microsoft/snmalloc/pull/550 ) in snmalloc
248249
- [Fixed compilation on modern glibc]( https://github.com/ssrg-vt/SlimGuard/pull/13 ) in SlimGuard
249250
- A [crash]( https://github.com/struct/isoalloc/issues/56 ) in isoalloc

build-bench-env.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ readonly version_sm=master # ~unmaintained since 2017
6262
readonly version_sn=0.6.2
6363
readonly version_tbb=v2021.9.0
6464
readonly version_tc=gperftools-2.15
65-
readonly version_tcg=bb24fb0a8be3a6ef52888d247097d05976b8918e # 2023-04-22
65+
readonly version_tcg=8febb4b4da2ab3b04862a8676fb5b506ef90aa42 # 2024-07-30
6666

6767
# benchmark versions
6868
readonly version_redis=6.2.7

0 commit comments

Comments
 (0)