Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Compilation error on latest Ubuntu #155

Closed
jvoisin opened this issue Dec 31, 2022 · 2 comments
Closed

Compilation error on latest Ubuntu #155

jvoisin opened this issue Dec 31, 2022 · 2 comments

Comments

@jvoisin
Copy link

jvoisin commented Dec 31, 2022 •
edited
Loading 

~/work/mimalloc-bench/mimalloc-bench/extern ~/work/mimalloc-bench/mimalloc-bench
Cloning into 'tcg'...
HEAD is now at 41fc126 Remove unused internal ID
2022/12/28 12:39:50 Downloading https://releases.bazel.build/6.0.0/release/bazel-6.0.0-linux-x86_64...
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
DEBUG: /home/runner/.cache/bazel/_bazel_runner/e1a81254a21a62a173ba14f5a82f08a1/external/rules_python/python/repositories.bzl:32:10: py_repositories is a no-op and is deprecated. You can remove this from your WORKSPACE file
Loading: 
Loading: 0 packages loaded
Analyzing: target //tcmalloc:tcmalloc (1 packages loaded, 0 targets configured)
Analyzing: target //tcmalloc:tcmalloc (30 packages loaded, 6 targets configured)
Analyzing: target //tcmalloc:tcmalloc (31 packages loaded, 45 targets configured)
ERROR: /home/runner/.cache/bazel/_bazel_runner/e1a81254a21a62a173ba14f5a82f08a1/external/bazel_tools/platforms/BUILD:89:6: in alias rule @bazel_tools//platforms:windows: Constraints from @bazel_tools//platforms have been removed. Please use constraints from @platforms repository embedded in Bazel, or preferably declare dependency on https://github.com/bazelbuild/platforms. See https://github.com/bazelbuild/bazel/issues/8622 for details.
ERROR: /home/runner/.cache/bazel/_bazel_runner/e1a81254a21a62a173ba14f5a82f08a1/external/bazel_tools/platforms/BUILD:89:6: Analysis of target '@bazel_tools//platforms:windows' failed
ERROR: /home/runner/work/mimalloc-bench/mimalloc-bench/extern/tcg/tcmalloc/BUILD:95:10: While resolving toolchains for target //tcmalloc:tcmalloc: invalid registered toolchain '@bazel_skylib//toolchains/unittest:cmd_toolchain': 
ERROR: Analysis of target '//tcmalloc:tcmalloc' failed; build aborted: 
INFO: Elapsed time: 12.250s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (33 packages loaded, 107 targets configured)
@ckennelly
Copy link
Collaborator

bazelbuild/bazel#8622 (comment) looks related here.

@jvoisin jvoisin mentioned this issue Jan 5, 2023
Closed
rjogrady referenced this issue Jan 13, 2023
@rjogrady @copybara-github
Fix tcmalloc build under bazel 6. Ensure we have a recent version of …
5ee6e26 
…bazel-skylib to avoid our dependencies pulling in an old one that is no longer compatible.

See bazelbuild/bazel#8622

PiperOrigin-RevId: 501899438
Change-Id: I2409cc0aeeabbefbeb781188a2deba6f5e491a0e
@ckennelly
Copy link
Collaborator

This was fixed by 5ee6e26.

@jvoisin jvoisin mentioned this issue Jul 30, 2024
Merged
jvoisin added a commit to daanx/mimalloc-bench that referenced this issue Jul 30, 2024
@jvoisin
Re-enable TCG
9af777a 
google/tcmalloc#179 and google/tcmalloc#155 are now fixed.
jvoisin added a commit to daanx/mimalloc-bench that referenced this issue Jul 30, 2024
@jvoisin
Re-enable TCG (#210)
5092307 
google/tcmalloc#179 and google/tcmalloc#155 are now fixed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ckennelly @jvoisin