New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Modify withSpinner.R to allow type=0 #18

Merged

daattali merged 2 commits into daattali:master from sTeamTraen:master

Jan 31, 2020

Contributor

sTeamTraen commented Jun 10, 2018 •

edited

Loading

Hi - I hope I've done this right.

This didn't need many changes:

Allowed a range of 0:8 instead of 1:8 for type.
Made the "Loading" message conditional on their being a spinner (i.e., "type=0" is completely silent; I guess this is a question of taste and design philosophy).
Removed what seemed to be an unnecessary sprintf() for the load of fallback.css (as I was working my way through the code trying to understand it).
Added load0.css to avoid a runtime error in the browser console.

Thanks for reading,
Nick


          Modify withSpinner.R to allow type=0

7e64848

Add load0.css

daattali mentioned this pull request

Feature request: allow type=0 #15

Closed


          Merge branch 'master' into master

482f308

daattali merged commit 6b4c24e into daattali:master

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet