Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix concurrency bug in reported file version #5912

Conversation

keyboardDrummer
Copy link
Member

@keyboardDrummer keyboardDrummer commented Nov 12, 2024

Fixes #5901 and possibly other failing tests

Description

  • For any files open in the editor, record the editor's version number when that file is read, and store this version number throughout compilation so it can be used when emitting notifications for this compilation.

How has this been tested?

  • The change in behavior only occurs for a particular race condition, which is difficult to trigger, so I have not added tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

MikaelMayer
MikaelMayer previously approved these changes Nov 12, 2024
Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this stabilizes the file version number per file instead of per compilation. Hope it works!

@keyboardDrummer
Copy link
Member Author

keyboardDrummer commented Nov 12, 2024

Looks like this stabilizes the file version number per file instead of per compilation. Hope it works!

Per file per compilation

@keyboardDrummer keyboardDrummer merged commit 7d80ca2 into dafny-lang:master Nov 13, 2024
22 checks passed
@keyboardDrummer keyboardDrummer deleted the fixConcurrencyBugInReportedFileVersion branch November 13, 2024 16:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test suite fails on Synchronization.ProjectManagerDatabaseTest.ChangeAndUndoProjectWithMultipleFiles
2 participants