Fix: {:only} on a per-file basis #5915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5730
Description
Previously, in multi files projects, an
{:only}on one member like a method was disabling verification on all other methods, including ones in other files.However, this is a bug, as the documentation of
{:only}states clearly that it disables verification on members in the same file.This PR ensures that the scope of an
{:only}attribute for a member is only the file itself.How has this been tested?
A multi file test has been added.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.