Move SVGViewport to functional component + add tests #27891
Merged
+876
−579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 342e536. |
hellendag
approved these changes
Feb 18, 2025
js_modules/dagster-ui/packages/ui-core/src/graph/SVGExporter.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/hooks/useSetStateUpdateCallback.tsx
Show resolved
Hide resolved
salazarm
deleted the
salazarm/refactor-svg-viewport-to-functional-component
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Hoping to get the asset-graph fully under test. Starting with the SVGViewport component.
I folded the PanAndZoom interactor into the component itself since we never used the NoneInteractor anywhere.
How I Tested These Changes
jest + manually tested the asset-graph