Include GrapheneUnauthorizedError in GrapheneTerminateRunsResultOrError #27925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 52f2c60. |
gibsondan
force-pushed
the
allowunauthorizedresponse
branch
from
65719f9 to
267d214
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -271,6 +272,14 @@ def test_cancel_runs_permission_failure(self, graphql_context: WorkspaceRequestC | |||
| in result.data["terminateRuns"]["terminateRunResults"][0]["message"] | |||
| ) | |||
|
|
|||
| def test_cancel_runs_non_existant_run(self, graphql_context: WorkspaceRequestContext): | |||
There was a problem hiding this comment.
The method name contains a spelling error - existant should be existent. This matches standard English spelling and improves code readability.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
gibsondan
force-pushed
the
allowunauthorizedresponse
branch
2 times, most recently
from
ddae0cb to
52f2c60
Compare
alangenfeld
approved these changes
Feb 19, 2025
gibsondan
force-pushed
the
allowunauthorizedresponse
branch
from
52f2c60 to
4f0a130
Compare
Summary: This mutation can fail a permissions check (in a somewhat odd edge case where the run doesn't exist at all...) so it should include this response type. Test Plan: BK > Insert changelog entry or delete this section.
gibsondan
force-pushed
the
allowunauthorizedresponse
branch
from
4f0a130 to
54ca6ff
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This mutation can fail a permissions check (in a somewhat odd edge case where the run doesn't exist at all...) so it should include this response type.
Test Plan:
BK