[Run Timeline] Don't drop job data if locations within the FutureTicksQuery fails #27944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 1d5a068. |
hellendag
approved these changes
Feb 20, 2025
cmpadden
pushed a commit
that referenced
this pull request
Feb 20, 2025
…sQuery fails (#27944) ## Summary & Motivation Currently, if the FutureTicksQuery itself fails we recover by returning the ongoing runs and complete runs data that we have. However, if the query doesn't fail then we end up iterating over all of the locations within it and constructing a `jobs` array with all of the rows of the timeline. The problem is that this construction relies on the jobs returned by FutureTicksQuery. If FutureTicksQuery doesn't return a particular job then we drop the data for that job completely. To fix this track which keys we've added via the FutureTicksQuery and then do a second pass where we add data for any jobs that were not in the FutureTicksQuery ## How I Tested These Changes Loaded the Run timeline for a customer with a failing location entry ## Changelog > Insert changelog entry or delete this section.
cmpadden
pushed a commit
that referenced
this pull request
Feb 20, 2025
…sQuery fails (#27944) ## Summary & Motivation Currently, if the FutureTicksQuery itself fails we recover by returning the ongoing runs and complete runs data that we have. However, if the query doesn't fail then we end up iterating over all of the locations within it and constructing a `jobs` array with all of the rows of the timeline. The problem is that this construction relies on the jobs returned by FutureTicksQuery. If FutureTicksQuery doesn't return a particular job then we drop the data for that job completely. To fix this track which keys we've added via the FutureTicksQuery and then do a second pass where we add data for any jobs that were not in the FutureTicksQuery ## How I Tested These Changes Loaded the Run timeline for a customer with a failing location entry ## Changelog > Insert changelog entry or delete this section.
gibsondan
pushed a commit
that referenced
this pull request
Feb 20, 2025
…sQuery fails (#27944) ## Summary & Motivation Currently, if the FutureTicksQuery itself fails we recover by returning the ongoing runs and complete runs data that we have. However, if the query doesn't fail then we end up iterating over all of the locations within it and constructing a `jobs` array with all of the rows of the timeline. The problem is that this construction relies on the jobs returned by FutureTicksQuery. If FutureTicksQuery doesn't return a particular job then we drop the data for that job completely. To fix this track which keys we've added via the FutureTicksQuery and then do a second pass where we add data for any jobs that were not in the FutureTicksQuery ## How I Tested These Changes Loaded the Run timeline for a customer with a failing location entry ## Changelog > Insert changelog entry or delete this section.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Currently, if the FutureTicksQuery itself fails we recover by returning the ongoing runs and complete runs data that we have.
However, if the query doesn't fail then we end up iterating over all of the locations within it and constructing a
jobsarray with all of the rows of the timeline. The problem is that this construction relies on the jobs returned by FutureTicksQuery. If FutureTicksQuery doesn't return a particular job then we drop the data for that job completely. To fix this track which keys we've added via the FutureTicksQuery and then do a second pass where we add data for any jobs that were not in the FutureTicksQueryHow I Tested These Changes
Loaded the Run timeline for a customer with a failing location entry
Changelog