Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[components] Rename dg check component -> dg check yaml #27962

Merged
merged 1 commit into from
Feb 21, 2025
Merged

[components] Rename dg check component -> dg check yaml #27962

merged 1 commit into from
Feb 21, 2025

Conversation

smackesey
Copy link
Collaborator

@smackesey smackesey commented Feb 20, 2025 •
edited
Loading

Summary & Motivation

Renames dg check component to dg check yaml. This opens the door for dg check definitions.

How I Tested These Changes

Existing test suite.

@smackesey smackesey mentioned this pull request Feb 20, 2025
Merged
@smackesey Graphite App
Copy link
Collaborator Author

smackesey commented Feb 20, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@smackesey smackesey marked this pull request as ready for review February 20, 2025 21:26
@smackesey smackesey requested a review from neverett as a code owner February 20, 2025 21:26
@smackesey smackesey force-pushed the sean/components/check-component-check-yaml branch from ac79eca to 0648583 Compare February 20, 2025 21:29
benpankow
benpankow approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@benpankow benpankow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, this name is more accurate anyway since we don't do complete "correctness" checking beyond yaml validation

@smackesey smackesey removed the request for review from neverett February 20, 2025 21:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-eh8goxmtg-elementl.vercel.app
https://sean-components-check-component-check-yaml.archive.dagster-docs.io

Direct link to changed pages:

@smackesey smackesey force-pushed the sean/components/check-component-check-yaml branch from 0648583 to bc4c698 Compare February 20, 2025 21:54
schrockn
schrockn approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic change and I think provides the value of "verb-first" quite definitively.

Base automatically changed from sean/components/info-inspect to master February 21, 2025 17:54
@smackesey smackesey force-pushed the sean/components/check-component-check-yaml branch from bc4c698 to bfa6e14 Compare February 21, 2025 17:56
@smackesey smackesey merged commit a90d446 into master Feb 21, 2025
6 checks passed
@smackesey smackesey deleted the sean/components/check-component-check-yaml branch February 21, 2025 18:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@benpankow benpankow benpankow approved these changes

@schrockn schrockn schrockn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smackesey @benpankow @schrockn