Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Avoid unsupported type constraint #329

Merged
merged 1 commit into from
Dec 29, 2016
Merged

Avoid unsupported type constraint #329

merged 1 commit into from
Dec 29, 2016

Conversation

dahlbyk
Copy link
Owner

@dahlbyk dahlbyk commented Dec 29, 2016

Fixes PowerShell 2.0 regression from #319.

cc @lzybkr

@lzybkr
Copy link
Collaborator

lzybkr commented Dec 29, 2016

LGTM

@dahlbyk dahlbyk merged commit 22cc20b into master Dec 29, 2016
@dahlbyk dahlbyk deleted the gh319-v2-regression branch December 29, 2016 20:43
@rkeithhill
Copy link
Collaborator

So I don't get a crash on v2 (unsupported type constraint) but the numbers are missing:
image
Same for files in the index if I add the file to the index. I'll look into this. Hopefully it is something easy to fix.

@rkeithhill
Copy link
Collaborator

OK, on v2 it looks like the Index and Working properties are coming through as type string - value -NoEnumerate. I'll see if I can fix it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rkeithhill rkeithhill Awaiting requested review from rkeithhill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dahlbyk @lzybkr @rkeithhill