Use pscustomobject cast for sorted output of $GitPromptSettings #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get output sorted like the original source for `$GitPromptSettings`, we can use a cast instead of `New-Object`. This does change the type of the object in V2 from `PSObject` to `hashtable`, but it doesn't appear to cause any problems because property syntax works either way.
|
Verified. V2 still works (although the properties don't display in definition order). OTOH V5 (and probably V3/4) do display the properties in the order they were defined. |
|
Sufficiently fixes #344 for 0.7.0. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get output sorted like the original source for
$GitPromptSettings,we can use a cast instead of
New-Object.This does change the type of the object in V2 from
PSObjecttohashtable, but it doesn't appear to cause any problems becauseproperty syntax works either way.