Fix 'Write-Prompt' to be able use Black as foreground color. #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzybkr
approved these changes
Apr 17, 2017
rkeithhill
reviewed
Apr 17, 2017
src/GitPrompt.ps1
Outdated
| @@ -132,7 +132,7 @@ if (Get-Module NuGet) { | |||
|
|
|||
| function Write-Prompt($Object, $ForegroundColor = $null, $BackgroundColor = $null) { | |||
| $s = $global:GitPromptSettings | |||
| if ($s -and !$ForegroundColor) { | |||
| if ($s -and $ForegroundColor -eq $null) { | |||
There was a problem hiding this comment.
Good catch! To eliminate a PSScriptAnalyzer warning in VSCode, would you mind changing that ever so slightly to:
if ($s -and ($null -eq $ForegroundColor)) { There was a problem hiding this comment.
Thanks for the info about PSScriptAnalyzer.
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation replaces 'Black' color with DefaultForegroundColor. This breaks some themes from the oh-my-posh package.