Pass "git.exe" instead of "git" to Get-Command

[mikesigs]

Passing just "git" to get-command causes the script to fail if you have an alias called "git". For example, I have hub installed , which recommends aliasing git=hub. However, after doing this it breaks this posh-git script because get-command git returns the new alias which has no path.

Running get-command git returns:
CommandType Name Version Source

-----------     ----                                               -------    ------
Alias           git -> hub.exe

But get-command git.exe returns:
CommandType Name Version Source

-----------     ----                                               -------    ------
Application     git.exe                                            2.13.2.1   C:\Program Files\Git\cmd\git.exe

[dahlbyk]

This works for me. There's a small chance this is a regression for folks with an older version of Git, which may have only put git.cmd in $PATH, but I'm content to test that in production.

[dahlbyk]

(Thanks!)

[mikesigs]

My pleasure. Good call on looking for *git.cmd*. I suppose the script could be updated to look for both variants.

…

On Mon, 10 Jul 2017 at 16:41 Keith Dahlby ***@***.***> wrote: (Thanks!) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#478 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAxgqWoaFcGQJFaU0-F5QCy7p2UFLGA9ks5sMqidgaJpZM4OTfYU> .

[dahlbyk]

I expect Get-Command git.exe,git.cmd -ErrorAction SilentlyContinue would do the trick?

[mikesigs]

A bit further digging and I would have this much better fix: Get-Command git -CommandType Application

…

On Mon, 10 Jul 2017 at 16:45 Keith Dahlby ***@***.***> wrote: I expect Get-Command git.exe,git.cmd -ErrorAction SilentlyContinue would do the trick? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#478 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAxgqTW8ZtioYCbjUaUpHeqnqhybQCnYks5sMqmdgaJpZM4OTfYU> .

[rkeithhill]

Unfortunately this (original fix in this PR) won't work when running posh-git on PS Core on Linux / macOS:

[rkeithhill]

A better fix for this is to use the -CommandType Application parameter. Hehe, sorry I didn't see you last comment. Yup, much better fix.