Eliminate reflection warnings from test suite #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated with a couple tweaks to work in Clojure 1.3; Travis CI is happy now. |
|
When running the test with |
|
Ouch! Hadn't run it with :all (obviously). I will fix it -- thanks. |
|
Merged, thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This obviously has no effect on functionality aside from an infinitesimal performance increase, but I think it's desirable to have clean test suite output without lots of spewing warnings, and to reduce the number of compiler warnings for users who use the library. With this patch, "lein test" passes with no warnings.
I am a Clojure newbie so I may have failed to follow proper style; feedback welcome if you have time to give any.