Add options for how to flatten/encode form and query parameters #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the following new parameters:
- `:ignore-nested-query-string` :: Do not handle nested query parameters specially, treat them as
the exact text they come in as. Defaults to *false*.
- `:flatten-nested-form-params` :: Flatten nested (map within a map) `:form-params` before encoding
it as the body. Defaults to *false*, meaning form params are encoded only
`x-www-form-urlencoded`.
- `:flatten-nested-keys` :: An advanced way of specifying which keys having nested maps should be
flattened. A middleware function checks the previous two options
(`:ignore-nested-query-string` and `:flatten-nested-form-params`) and modifies this to be the
list that will be flattened.
Resolves #427
dakrone
added a commit
that referenced
this pull request
Feb 13, 2018
* Add options for how to flatten/encode form and query parameters
This adds the following new parameters:
- `:ignore-nested-query-string` :: Do not handle nested query parameters specially, treat them as
the exact text they come in as. Defaults to *false*.
- `:flatten-nested-form-params` :: Flatten nested (map within a map) `:form-params` before encoding
it as the body. Defaults to *false*, meaning form params are encoded only
`x-www-form-urlencoded`.
- `:flatten-nested-keys` :: An advanced way of specifying which keys having nested maps should be
flattened. A middleware function checks the previous two options
(`:ignore-nested-query-string` and `:flatten-nested-form-params`) and modifies this to be the
list that will be flattened.
Resolves #427
* Add a test for the new middleware
* Throw IllegalArgumentException when multiple options are specified
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following new parameters:
:ignore-nested-query-string:: Do not handle nested query parameters specially, treat them asthe exact text they come in as. Defaults to false.
:flatten-nested-form-params:: Flatten nested (map within a map):form-paramsbefore encodingit as the body. Defaults to false, meaning form params are encoded only
x-www-form-urlencoded.:flatten-nested-keys:: An advanced way of specifying which keys having nested maps should beflattened. A middleware function checks the previous two options
(
:ignore-nested-query-stringand:flatten-nested-form-params) and modifies this to be thelist that will be flattened.
Resolves #427